-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schemas/browsers)!: merge accepts_{flags,webextension}
fields into accepts
array
#25825
base: main
Are you sure you want to change the base?
Conversation
accepts_{flags,webextension}
fields into accepts
array
accepts_{flags,webextension}
fields into accepts
arrayaccepts_{flags,webextension}
fields into accepts
array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that we're adding more flags for featuresets browsers allow, this makes sense.
Small nit: perhaps it would make more sense to make this a dictionary instead, so that we can add version numbers for when a featureset was introduced?
@queengooborg I'm open to discussing the use case behind making this a dictionary, but I would prefer to start with this basic approach, to avoid scope creep. |
I think that using a dictionary instead of an array of strings would have the following benefits:
|
165cbd2
to
e6c9b80
Compare
Done in a7ede72. |
e6c9b80
to
27fcdd6
Compare
27fcdd6
to
30806bc
Compare
30806bc
to
a7ede72
Compare
|
||
An optional boolean indicating whether the browser supports flags. If it is set to `false`, flag data will not be allowed for that browser. | ||
An optional object indicating which additional features the browser supports. Possible properties are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An optional object indicating which additional features the browser supports. Possible properties are: | |
An object indicating which additional features the browser supports. Possible properties are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo @queengooborg's comment.
Summary
Merges the
accepts_flags
andaccepts_webextensions
fields in the browser schema into a singleaccepts
object with boolean propertiesflags
andwebextensions
.Important
This is a breaking change, as we expose these fields in the built
data.json
.Test results and supporting details
Prepares for #25804, which adds
webdriver-bidi
.Related issues